steve-chavez
9847e60dca
When having one-to-many relationships like: person -< message[sender] person -< message[recipient] person_detail -< message[sender] person_detail -< message[recipient] Where person_detail is a view of person. This request: GET "/message?select=*,sender(*)" Is ambiguous. Both person or person_detail could be embedded. Until now we have returned the first detected relationship but now we return a 300 Multiple Choices error with a descriptive error message asking the user to disambiguate. This is more helpful for the user and also aids in cases of more complex relationships.
74 lines
2.7 KiB
Haskell
74 lines
2.7 KiB
Haskell
module Feature.QueryLimitedSpec where
|
|
|
|
import Network.Wai (Application)
|
|
import Network.Wai.Test (SResponse (simpleHeaders, simpleStatus))
|
|
|
|
import Network.HTTP.Types
|
|
import Test.Hspec
|
|
import Test.Hspec.Wai
|
|
import Test.Hspec.Wai.JSON
|
|
|
|
import Protolude hiding (get)
|
|
import SpecHelper
|
|
|
|
spec :: SpecWith Application
|
|
spec =
|
|
describe "Requesting many items with server limits(max-rows) enabled" $ do
|
|
it "restricts results" $
|
|
get "/items"
|
|
`shouldRespondWith` [json| [{"id":1},{"id":2}] |]
|
|
{ matchStatus = 200
|
|
, matchHeaders = ["Content-Range" <:> "0-1/*"]
|
|
}
|
|
|
|
it "respects additional client limiting" $ do
|
|
r <- request methodGet "/items"
|
|
(rangeHdrs $ ByteRangeFromTo 0 0) ""
|
|
liftIO $ do
|
|
simpleHeaders r `shouldSatisfy`
|
|
matchHeader "Content-Range" "0-0/*"
|
|
simpleStatus r `shouldBe` ok200
|
|
|
|
it "works on all levels" $
|
|
get "/users?select=id,tasks(id)&order=id.asc&tasks.order=id.asc"
|
|
`shouldRespondWith` [json|[{"id":1,"tasks":[{"id":1},{"id":2}]},{"id":2,"tasks":[{"id":5},{"id":6}]}]|]
|
|
{ matchStatus = 200
|
|
, matchHeaders = ["Content-Range" <:> "0-1/*"]
|
|
}
|
|
|
|
it "succeeds in getting parent embeds despite the limit, see #647" $
|
|
get "/tasks?select=id,project:projects(id)&id=gt.5"
|
|
`shouldRespondWith` [json|[{"id":6,"project":{"id":3}},{"id":7,"project":{"id":4}}]|]
|
|
{ matchStatus = 200
|
|
, matchHeaders = ["Content-Range" <:> "0-1/*"]
|
|
}
|
|
|
|
it "can offset the parent embed, being consistent with the other embed types" $
|
|
get "/tasks?select=id,project:projects(id)&id=gt.5&project.offset=1"
|
|
`shouldRespondWith` [json|[{"id":6,"project":null}, {"id":7,"project":null}]|]
|
|
{ matchStatus = 200
|
|
, matchHeaders = ["Content-Range" <:> "0-1/*"]
|
|
}
|
|
|
|
context "count=estimated" $ do
|
|
it "uses the query planner guess when query rows > maxRows" $
|
|
request methodHead "/getallprojects_view" [("Prefer", "count=estimated")] ""
|
|
`shouldRespondWith` ""
|
|
{ matchStatus = 206
|
|
, matchHeaders = ["Content-Range" <:> "0-1/2019"]
|
|
}
|
|
|
|
it "gives exact count when query rows <= maxRows" $
|
|
request methodHead "/getallprojects_view?id=lt.3" [("Prefer", "count=estimated")] ""
|
|
`shouldRespondWith` ""
|
|
{ matchStatus = 200
|
|
, matchHeaders = ["Content-Range" <:> "0-1/2"]
|
|
}
|
|
|
|
it "only uses the query planner guess if it's indeed greater than the exact count" $
|
|
request methodHead "/get_projects_above_view" [("Prefer", "count=estimated")] ""
|
|
`shouldRespondWith` ""
|
|
{ matchStatus = 206
|
|
, matchHeaders = ["Content-Range" <:> "0-1/3"]
|
|
}
|