fix: Ignore leading and trailing spaces in column names, fts languages and casts

Fixes #2285

Signed-off-by: Wolfgang Walther <walther@technowledgy.de>

CHANGELOG.md

@@ -24,6 +24,7 @@ This project adheres to [Semantic Versioning](http://semver.org/).
  - #2534, Fix embedding a computed relationship with a normal relationship - @steve-chavez
  - #2362, Fix error message when [] is used inside select - @wolfgangwalther
  - #2475, Disallow !inner on computed columns - @wolfgangwalther
+ - #2285, Ignore leading and trailing spaces in column names when parsing the query string - @wolfgangwalther
 
 ### Changed
 

src/PostgREST/ApiRequest/QueryParams.hs

@@ -356,6 +356,12 @@ pStar = string "*" $> "*"
 --
 -- >>> P.parse pFieldName "" "\":\""
 -- Right ":"
+--
+-- >>> P.parse pFieldName "" " no leading or trailing spaces "
+-- Right "no leading or trailing spaces"
+--
+-- >>> P.parse pFieldName "" "\" leading and trailing spaces \""
+-- Right " leading and trailing spaces "
 pFieldName :: Parser Text
 pFieldName =
   pQuotedValue <|>
@@ -630,8 +636,11 @@ pLogicPath = do
 pColumns :: Parser [FieldName]
 pColumns = pFieldName `sepBy1` lexeme (char ',')
 
-pIdentifier :: Parser [Char]
+pIdentifier :: Parser Text
-pIdentifier = many1 $ letter <|> digit <|> oneOf "_ $"
+pIdentifier = T.strip . toS <$> many1 pIdentifierChar
+
+pIdentifierChar :: Parser Char
+pIdentifierChar = letter <|> digit <|> oneOf "_ $"
 
 mapError :: Either ParseError a -> Either QPError a
 mapError = mapLeft translateError