Fix overloaded computed columns on RPC (#1473)

* fix some typos and spelling

* fix pg_source CTE name should be prefixed with pgrst_

* added tests for overloaded computed columns on patch calls

test/fixtures/data.sql

@@ -207,6 +207,35 @@ INSERT INTO items VALUES (15);
 SELECT pg_catalog.setval('items_id_seq', 15, true);
 
 
+--
+-- Data for Name: items2; Type: TABLE DATA; Schema: test; Owner: -
+--
+
+TRUNCATE TABLE items2 CASCADE;
+INSERT INTO items2 VALUES (1);
+INSERT INTO items2 VALUES (2);
+INSERT INTO items2 VALUES (3);
+INSERT INTO items2 VALUES (4);
+INSERT INTO items2 VALUES (5);
+INSERT INTO items2 VALUES (6);
+INSERT INTO items2 VALUES (7);
+INSERT INTO items2 VALUES (8);
+INSERT INTO items2 VALUES (9);
+INSERT INTO items2 VALUES (10);
+INSERT INTO items2 VALUES (11);
+INSERT INTO items2 VALUES (12);
+INSERT INTO items2 VALUES (13);
+INSERT INTO items2 VALUES (14);
+INSERT INTO items2 VALUES (15);
+
+
+--
+-- Name: items_id_seq; Type: SEQUENCE SET; Schema: test; Owner: -
+--
+
+SELECT pg_catalog.setval('items2_id_seq', 15, true);
+
+
 --
 -- Data for Name: json; Type: TABLE DATA; Schema: test; Owner: -
 --

test/fixtures/privileges.sql

@@ -15,6 +15,7 @@ SET search_path = test, "تست", pg_catalog;
 
 GRANT ALL ON TABLE
     items
+    , items2
     , "articleStars"
     , articles
     , auto_incrementing_pk
@@ -127,8 +128,8 @@ GRANT ALL ON TABLE
     , v1.parents
     , v2.parents
     , v2.another_table
-    , v1.childs
-    , v2.childs
+    , v1.children
+    , v2.children
 TO postgrest_test_anonymous;
 
 GRANT INSERT ON TABLE insertonly TO postgrest_test_anonymous;
@@ -138,8 +139,8 @@ GRANT USAGE ON SEQUENCE
     , items_id_seq
     , callcounter_count
     , leak_id_seq
-    , v1.childs_id_seq
-    , v2.childs_id_seq
+    , v1.children_id_seq
+    , v2.children_id_seq
 TO postgrest_test_anonymous;
 
 -- Privileges for non anonymous users

test/fixtures/schema.sql

@@ -109,10 +109,28 @@ CREATE TABLE items (
     id bigserial primary key
 );
 
+CREATE TABLE items2 (
+    id bigserial primary key
+);
+
+CREATE FUNCTION search(id BIGINT) RETURNS SETOF items
+    LANGUAGE plpgsql
+    AS $$BEGIN
+        RETURN QUERY SELECT items.id FROM items WHERE items.id=search.id;
+    END$$;
+
 CREATE FUNCTION always_true(test.items) RETURNS boolean
     LANGUAGE sql STABLE
     AS $$ SELECT true $$;
 
+CREATE FUNCTION computed_overload(test.items) RETURNS boolean
+    LANGUAGE sql STABLE
+    AS $$ SELECT true $$;
+
+CREATE FUNCTION computed_overload(test.items2) RETURNS boolean
+    LANGUAGE sql STABLE
+    AS $$ SELECT true $$;
+
 CREATE FUNCTION is_first(test.items) RETURNS boolean
     LANGUAGE sql STABLE
     AS $$ SELECT $1.id = 1 $$;
@@ -1702,7 +1720,7 @@ create table v1.parents (
 , name text
 );
 
-create table v1.childs (
+create table v1.children (
   id       serial primary key
 , name    text
 , parent_id int
@@ -1720,7 +1738,7 @@ create table v2.parents (
 , name text
 );
 
-create table v2.childs (
+create table v2.children (
   id    serial primary key
 , name text
 , parent_id int