jimmy/postgrest
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

add: log error when db-schemas config contain restricted schemas

Browse Source 
We don't allow accessing schemas "pg_catalog" and "information_schema".
Instead of silently failing requests on these schemas, this now adds
logging an error on startup when these schemas are found in `db-schemas`
config.

Signed-off-by: Taimoor Zaeem <taimoorzaeem@gmail.com>
This commit is contained in:
Taimoor Zaeem
2025-12-11 14:28:08 -05:00
committed by Steve Chavez
parent c232e97f80
commit abad47ff1b
5 changed files with 40 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/io/test_cli.py
+15
View File
@@ -286,6 +286,21 @@ def test_jwt_secret_min_length(defaultenv):
assert "The JWT secret must be at least 32 characters long." in error
@pytest.mark.parametrize("restricted_schema", FIXTURES["restrictedschemas"])
def test_restricted_db_schemas(restricted_schema, defaultenv):
"Should print error when db-schemas config contain pg_catalog or information_schema"
# test when single schema is given in db-schemas
env = {**defaultenv, "PGRST_DB_SCHEMAS": restricted_schema}
error = cli(["--dump-config"], env=env, expect_error=True)
assert f"db-schemas does not allow schema: '{restricted_schema}'" in error
# test when multiple schemas are given in db-schemas
env = {**defaultenv, "PGRST_DB_SCHEMAS": f"public, {restricted_schema}"}
error = cli(["--dump-config"], env=env, expect_error=True)
assert f"db-schemas does not allow schema: '{restricted_schema}'" in error
# TODO: Improve readability of "--ready" healthcheck tests
@pytest.mark.parametrize("host", ["127.0.0.1", "::1"], ids=["IPv4", "IPv6"])
def test_cli_ready_flag_success(host, defaultenv):