Revert "add: config db-timezone-enabled for optional querying of timezones"

This reverts commit d6c338d588.

src/library/PostgREST/Config.hs

@@ -95,7 +95,6 @@ data AppConfig = AppConfig
   , configDbSchemas                 :: NonEmpty Text
   , configDbConfig                  :: Bool
   , configDbPreConfig               :: Maybe QualifiedIdentifier
-  , configDbTimezoneEnabled         :: Bool
   , configDbTxAllowOverride         :: Bool
   , configDbTxRollbackAll           :: Bool
   , configDbUri                     :: Text
@@ -186,7 +185,6 @@ toText conf =
       ,("db-schemas",                q . T.intercalate "," . toList . configDbSchemas)
       ,("db-config",                     T.toLower . show . configDbConfig)
       ,("db-pre-config",             q . maybe mempty dumpQi . configDbPreConfig)
-      ,("db-timezone-enabled",           T.toLower . show . configDbTimezoneEnabled)
       ,("db-tx-end",                 q . showTxEnd)
       ,("db-uri",                    q . configDbUri)
       ,("jwt-aud",                   q . fromMaybe mempty . configJwtAudience)
@@ -301,7 +299,6 @@ parser optPath env dbSettings roleSettings roleIsolationLvl =
     <*> parseDbSchemas "db-schemas" "db-schema"
     <*> (fromMaybe True <$> optBool "db-config")
     <*> (fmap toQi <$> optString "db-pre-config")
-    <*> (fromMaybe True <$> optBool "db-timezone-enabled")
     <*> parseTxEnd "db-tx-end" snd
     <*> parseTxEnd "db-tx-end" fst
     <*> (fromMaybe "postgresql://" <$> optString "db-uri")
@@ -737,9 +734,6 @@ exampleConfigFile = S.unlines
   , "## The name of which database schema to expose to REST clients"
   , "db-schemas = \"public\""
   , ""
-  , "## Enable quering pg_timezone_names from db"
-  , "# db-timezone-enabled = true"
-  , ""
   , "## How to terminate database transactions"
   , "## Possible values are:"
   , "## commit (default)"

src/library/PostgREST/Config/Database.hs

@@ -57,7 +57,6 @@ dbSettingsNames =
   ,"db_prepared_statements"
   ,"db_root_spec"
   ,"db_schemas"
-  ,"db_timezone_enabled"
   ,"db_tx_end"
   ,"db_hoisted_tx_settings"
   ,"jwt_aud"

src/library/PostgREST/SchemaCache.hs

@@ -160,15 +160,13 @@ querySchemaCache pgVer conf@AppConfig{..} = do
   cRels   <- sqlTimedStmt gucCRels mempty allComputedRels
   reps    <- sqlTimedStmt gucDReps conf   dataRepresentations
   mHdlers <- sqlTimedStmt gucMHdrs conf   mediaHandlers
-  tzones  <- if configDbTimezoneEnabled
-    then sqlTimedStmt gucTzones mempty timezones
-    else pure S.empty
+  tzones  <- sqlTimedStmt gucTzones mempty timezones
 
   for_ configInternalSCQuerySleepSnd (`SQL.statement` sleepCall) -- only used for testing
 
   qsTime <-
     if isLogDebug
-      then Just <$> SQL.statement mempty (extractTimings configDbTimezoneEnabled)
+      then Just <$> SQL.statement mempty (extractTimings True)
       else pure Nothing
 
   let tabsWViewsPks = addViewPrimaryKeys tabs keyDeps