diff --git a/postgrest.cabal b/postgrest.cabal index cb235c421..4f27a5e5a 100644 --- a/postgrest.cabal +++ b/postgrest.cabal @@ -76,10 +76,9 @@ library , network-uri , optparse-applicative >= 0.13 && < 0.15 , parsec - , protolude >= 0.2 && < 0.2.2 + , protolude >= 0.2.2 , Ranged-sets == 0.3.0 , regex-tdfa - , safe , scientific , swagger2 , text diff --git a/src/PostgREST/ApiRequest.hs b/src/PostgREST/ApiRequest.hs index ed87bd98f..abd1a25e2 100644 --- a/src/PostgREST/ApiRequest.hs +++ b/src/PostgREST/ApiRequest.hs @@ -105,7 +105,7 @@ userApiRequest :: Schema -> Request -> RequestBody -> Either ApiRequestError Api userApiRequest schema req reqBody | isTargetingProc && method `notElem` ["GET", "POST"] = Left ActionInappropriate | topLevelRange == emptyRange = Left InvalidRange - | shouldParsePayload && isLeft payload = either (Left . InvalidBody . toS) undefined payload + | shouldParsePayload && isLeft payload = either (Left . InvalidBody . toS) witness payload | otherwise = Right ApiRequest { iAction = action , iTarget = target diff --git a/src/PostgREST/App.hs b/src/PostgREST/App.hs index 544a3b4d0..022d95acc 100644 --- a/src/PostgREST/App.hs +++ b/src/PostgREST/App.hs @@ -61,7 +61,6 @@ import PostgREST.OpenAPI import Data.Function (id) import Protolude hiding (intercalate, Proxy) -import Safe (headMay) postgrest :: AppConfig -> IORef (Maybe DbStructure) -> P.Pool -> IO UTCTime -> IO () -> Application postgrest conf refDbStructure pool getTime worker = diff --git a/src/PostgREST/DbRequestBuilder.hs b/src/PostgREST/DbRequestBuilder.hs index 495b5b692..597b65b3b 100644 --- a/src/PostgREST/DbRequestBuilder.hs +++ b/src/PostgREST/DbRequestBuilder.hs @@ -231,7 +231,7 @@ getJoinConditions (Relation Table{tableSchema=tSchema, tableName=tN} cols Table{ | typ == Many -> let ltN = fromMaybe "" (tableName <$> lt) in zipWith (toJoinCondition tN ltN) cols (fromMaybe [] lc1) ++ zipWith (toJoinCondition ftN ltN) fcs (fromMaybe [] lc2) - | typ == Root -> undefined + | typ == Root -> witness where toJoinCondition :: Text -> Text -> Column -> Column -> JoinCondition toJoinCondition tb ftb c fc = diff --git a/src/PostgREST/QueryBuilder.hs b/src/PostgREST/QueryBuilder.hs index 04600dbf0..5a8522a49 100644 --- a/src/PostgREST/QueryBuilder.hs +++ b/src/PostgREST/QueryBuilder.hs @@ -207,7 +207,7 @@ pgFmtLit x = else slashed requestToCountQuery :: Schema -> DbRequest -> SqlQuery -requestToCountQuery _ (DbMutate _) = undefined +requestToCountQuery _ (DbMutate _) = witness requestToCountQuery schema (DbRead (Node (Select{where_=logicForest}, (mainTbl, _, _, _, _)) _)) = unwords [ "SELECT pg_catalog.count(*)", @@ -272,7 +272,7 @@ requestToQuery schema isParent (DbRead (Node (Select colSelects tbls logicForest --the following is just to remove the warning --getQueryParts is not total but requestToQuery is called only after addJoinConditions which ensures the only --posible relations are Child Parent Many - getQueryParts _ _ = undefined + getQueryParts _ _ = witness requestToQuery schema _ (DbMutate (Insert mainTbl pkCols p@(PayloadJSON _ pType pKeys) onConflct logicForest returnings)) = unwords [ ("WITH " <> ignoredBody) `emptyOnFalse` not payloadIsEmpty, diff --git a/stack.yaml b/stack.yaml index 9703e1211..9a2c218d8 100644 --- a/stack.yaml +++ b/stack.yaml @@ -5,7 +5,7 @@ extra-deps: - hjsonpointer-1.1.1 - hjsonschema-1.5.0.1 - Ranged-sets-0.3.0 - - protolude-0.2 + - protolude-0.2.2 - hasql-1.1 - hasql-pool-0.4.3 - hasql-transaction-0.5.2