From 99b8246d6e72b14e11c877eec598fa13c3157183 Mon Sep 17 00:00:00 2001
From: steve-chavez <stevechavezast@gmail.com>
Date: Thu, 11 Dec 2025 20:02:15 -0500
Subject: [PATCH] nix: add --method for postgrest-loadtest

Currently the `postgrest-loadtest -k jwt-*` loadtests use the OPTIONS method,
which is good for isolating the perf changes for JWT auth.

But using GET is more accurate for actual perf improvements,
since it actually hits the database.

This adds a method argument for postgrest-loadtest, so GET can be used like:

```
postgrest-loadtest -k jwt-hs --method GET
```

CI is not changed, this is mostly useful for manually checking variance.
---
 nix/tools/generate_targets.py | 31 +++++++++++++++++++++++++++----
 nix/tools/loadtest.nix        | 14 ++++++++------
 2 files changed, 35 insertions(+), 10 deletions(-)

diff --git a/nix/tools/generate_targets.py b/nix/tools/generate_targets.py
index 762a2c21a..6de5a6a1e 100644
--- a/nix/tools/generate_targets.py
+++ b/nix/tools/generate_targets.py
@@ -18,6 +18,7 @@ import jwt
 import jwcrypto.jwk as jwk
 from typing import Optional
 from pathlib import Path
+from enum import Enum
 
 URL = "http://postgrest"
 
@@ -44,8 +45,21 @@ def generate_jwt(now: int, exp_inc: Optional[int], is_hs: bool) -> str:
     return jwt.encode(payload, k, alg)
 
 
-def append_targets(lines: list[str], token: str):
-    lines.append(f"OPTIONS {URL}/authors_only")
+HTTP_METHODS = (
+    "GET",
+    "OPTIONS",
+)
+
+HttpMethod = Enum(
+    "HttpMethod",
+    {method: method for method in HTTP_METHODS},
+    type=str,
+    module=__name__,
+)
+
+
+def append_targets(lines: list[str], token: str, http_method: HttpMethod):
+    lines.append(f"{http_method.value} {URL}/authors_only")
     lines.append(f"Authorization: Bearer {token}")
     lines.append("")  # blank line to separate requests
 
@@ -73,11 +87,20 @@ def main():
         default=None,
         help="Path for generating a RSA JWK file to sign tokens with",
     )
+    parser.add_argument(
+        "--method",
+        dest="http_method",
+        choices=list(HTTP_METHODS),
+        default=None,
+        help="HTTP method for the vegeta targets",
+    )
 
     args = parser.parse_args()
 
     is_hs = args.jwk_path is None
 
+    http_method = HttpMethod(args.http_method)
+
     nsamples = 1000
     if is_hs:
         ntargets = 200000
@@ -122,13 +145,13 @@ def main():
 
         for i in range(ntargets):
             token = generate_jwt(now, inc + i // 1000, is_hs)
-            append_targets(lines, token)
+            append_targets(lines, token, http_method)
 
     else:
         tokens = [generate_jwt(now, None, is_hs) for _ in range(nsamples)]
         for i in range(ntargets):
             token = random.choice(tokens)
-            append_targets(lines, token)
+            append_targets(lines, token, http_method)
 
     try:
         with open(args.output, "w") as f:
diff --git a/nix/tools/loadtest.nix b/nix/tools/loadtest.nix
index 763dd3285..7b137312f 100644
--- a/nix/tools/loadtest.nix
+++ b/nix/tools/loadtest.nix
@@ -42,7 +42,9 @@ let
           "ARG_OPTIONAL_SINGLE([output], [o], [Filename to dump json output to], [./loadtest/result.bin])"
           "ARG_OPTIONAL_SINGLE([testdir], [t], [Directory to load tests and fixtures from], [./test/load])"
           "ARG_OPTIONAL_SINGLE([kind], [k], [Kind of loadtest], [mixed])"
+          "ARG_OPTIONAL_SINGLE([method],, [HTTP method used for the jwt loadtests], [OPTIONS])"
           "ARG_TYPE_GROUP_SET([KIND], [KIND], [kind], [mixed,jwt-hs,jwt-hs-cache,jwt-hs-cache-worst,jwt-rsa,jwt-rsa-cache,jwt-rsa-cache-worst])"
+          "ARG_TYPE_GROUP_SET([METHOD], [METHOD], [method], [OPTIONS,GET])"
           "ARG_OPTIONAL_SINGLE([monitor], [m], [Monitoring file], [./loadtest/result.csv])"
           "ARG_LEFTOVERS([additional vegeta arguments])"
         ];
@@ -69,33 +71,33 @@ let
 
         case "$_arg_kind" in
           jwt-hs)
-            ${genTargets} "$_arg_testdir"/gen_targets.http
+            ${genTargets} --method "$_arg_method" "$_arg_testdir"/gen_targets.http
             export PGRST_JWT_CACHE_MAX_ENTRIES="0"
             export PGRST_JWT_CACHE_MAX_LIFETIME="0"
             ;;
 
           jwt-hs-cache)
-            ${genTargets} "$_arg_testdir"/gen_targets.http
+            ${genTargets} --method "$_arg_method" "$_arg_testdir"/gen_targets.http
             ;;
 
           jwt-hs-cache-worst)
-            ${genTargets} --worst "$_arg_testdir"/gen_targets.http
+            ${genTargets} --method "$_arg_method" --worst "$_arg_testdir"/gen_targets.http
             ;;
 
           jwt-rsa)
-            ${genTargets} --rsa="$_arg_testdir"/gen_jwk.json "$_arg_testdir"/gen_targets.http
+            ${genTargets} --method "$_arg_method" --rsa="$_arg_testdir"/gen_jwk.json "$_arg_testdir"/gen_targets.http
             export PGRST_JWT_CACHE_MAX_ENTRIES="0"
             export PGRST_JWT_CACHE_MAX_LIFETIME="0"
             export PGRST_JWT_SECRET="@$_arg_testdir/gen_jwk.json"
             ;;
 
           jwt-rsa-cache)
-            ${genTargets} --rsa="$_arg_testdir"/gen_jwk.json "$_arg_testdir"/gen_targets.http
+            ${genTargets} --method "$_arg_method" --rsa="$_arg_testdir"/gen_jwk.json "$_arg_testdir"/gen_targets.http
             export PGRST_JWT_SECRET="@$_arg_testdir/gen_jwk.json"
             ;;
 
           jwt-rsa-cache-worst)
-            ${genTargets} --worst --rsa="$_arg_testdir"/gen_jwk.json "$_arg_testdir"/gen_targets.http
+            ${genTargets} --method "$_arg_method" --worst --rsa="$_arg_testdir"/gen_jwk.json "$_arg_testdir"/gen_targets.http
             export PGRST_JWT_SECRET="@$_arg_testdir/gen_jwk.json"
             ;;