perf: no caching for prefer timezone

`Prefer: timezone` no longer requires the schema cache. Previously this required caching `pg_timezone_names` which was slow in some systems. Closes https://github.com/PostgREST/postgrest/issues/5100 and https://github.com/PostgREST/postgrest/issues/4751.
2026-08-04 13:41:40 -05:00
parent a41396c425
commit 932c4f6328
12 changed files with 74 additions and 1323 deletions
@@ -9,52 +9,49 @@ import Protolude  hiding (get)
 import SpecHelper

 spec :: SpecWithConfig
-spec withConfig = withConfig baseCfg $
-  describe "test Prefer: timezone with db-timezone-enabled is true" $ do
-    context "test Prefer: timezone=America/Los_Angeles" $ do
-      it "should change timezone with handling=strict" $
-        request methodGet "/timestamps"
-          [("Prefer", "handling=strict, timezone=America/Los_Angeles")]
-          ""
-          `shouldRespondWith`
-          [json|[{"t":"2023-10-18T05:37:59.611-07:00"}, {"t":"2023-10-18T07:37:59.611-07:00"}, {"t":"2023-10-18T09:37:59.611-07:00"}]|]
-          { matchStatus = 200
-          , matchHeaders = [matchContentTypeJson
-                           , "Preference-Applied" <:> "handling=strict, timezone=America/Los_Angeles"]}
+spec withConfig = withConfig baseCfg $ do
+  context "test Prefer: timezone=America/Los_Angeles" $ do
+    it "should change timezone with handling=strict" $
+      request methodGet "/timestamps"
+        [("Prefer", "handling=strict, timezone=America/Los_Angeles")]
+        ""
+        `shouldRespondWith`
+        [json|[{"t":"2023-10-18T05:37:59.611-07:00"}, {"t":"2023-10-18T07:37:59.611-07:00"}, {"t":"2023-10-18T09:37:59.611-07:00"}]|]
+        { matchStatus = 200
+        , matchHeaders = [matchContentTypeJson
+                         , "Preference-Applied" <:> "handling=strict, timezone=America/Los_Angeles"]}

-      it "should change timezone without handling=strict" $
-        request methodGet "/timestamps"
-          [("Prefer", "timezone=America/Los_Angeles")]
-          ""
-          `shouldRespondWith`
-          [json|[{"t":"2023-10-18T05:37:59.611-07:00"}, {"t":"2023-10-18T07:37:59.611-07:00"}, {"t":"2023-10-18T09:37:59.611-07:00"}]|]
-          { matchStatus = 200
-          , matchHeaders = [matchContentTypeJson
-                           , "Preference-Applied" <:> "timezone=America/Los_Angeles"] }
+    it "should change timezone without handling=strict" $
+      request methodGet "/timestamps"
+        [("Prefer", "timezone=America/Los_Angeles")]
+        ""
+        `shouldRespondWith`
+        [json|[{"t":"2023-10-18T05:37:59.611-07:00"}, {"t":"2023-10-18T07:37:59.611-07:00"}, {"t":"2023-10-18T09:37:59.611-07:00"}]|]
+        { matchStatus = 200
+        , matchHeaders = [matchContentTypeJson
+                         , "Preference-Applied" <:> "timezone=America/Los_Angeles"] }

-    context "test Prefer: timezone=Invalid/Timezone" $ do
-      it "should throw error with handling=strict" $
-        request methodGet "/timestamps"
-          [("Prefer", "handling=strict, timezone=Invalid/Timezone")]
-          ""
-          `shouldRespondWith`
-          [json|{"code":"PGRST122","details":"Invalid preferences: timezone=Invalid/Timezone","hint":null,"message":"Invalid preferences given with handling=strict"}|]
-          { matchStatus = 400 }
+  context "test Prefer: timezone=Invalid/Timezone" $ do
+    it "should throw error without handling" $
+      request methodGet "/timestamps"
+        [("Prefer", "timezone=Invalid/Timezone")]
+        ""
+        `shouldRespondWith`
+        [json|{"code":"22023","details":null,"hint":null,"message":"invalid value for parameter \"TimeZone\": \"Invalid/Timezone\""}|]
+        { matchStatus = 400 }

-      it "should return with default timezone without handling or with handling=lenient" $ do
-        request methodGet "/timestamps"
-          [("Prefer", "timezone=Invalid/Timezone")]
-          ""
-          `shouldRespondWith`
-          [json|[{"t":"2023-10-18T12:37:59.611+00:00"}, {"t":"2023-10-18T14:37:59.611+00:00"}, {"t":"2023-10-18T16:37:59.611+00:00"}]|]
-          { matchStatus = 200
-          , matchHeaders = [matchContentTypeJson]}
+    it "should throw error with handling=strict" $
+      request methodGet "/timestamps"
+        [("Prefer", "handling=strict, timezone=Invalid/Timezone")]
+        ""
+        `shouldRespondWith`
+        [json|{"code":"22023","details":null,"hint":null,"message":"invalid value for parameter \"TimeZone\": \"Invalid/Timezone\""}|]
+        { matchStatus = 400 }

-        request methodGet "/timestamps"
-          [("Prefer", "handling=lenient, timezone=Invalid/Timezone")]
-          ""
-          `shouldRespondWith`
-          [json|[{"t":"2023-10-18T12:37:59.611+00:00"}, {"t":"2023-10-18T14:37:59.611+00:00"}, {"t":"2023-10-18T16:37:59.611+00:00"}]|]
-          { matchStatus = 200
-          , matchHeaders = [matchContentTypeJson
-                           , "Preference-Applied" <:> "handling=lenient"]}
+    it "should throw error with handling=lenient" $
+      request methodGet "/timestamps"
+        [("Prefer", "handling=lenient, timezone=Invalid/Timezone")]
+        ""
+        `shouldRespondWith`
+        [json|{"code":"22023","details":null,"hint":null,"message":"invalid value for parameter \"TimeZone\": \"Invalid/Timezone\""}|]
+        { matchStatus = 400 }