fix: no empty tx on bad HTTP method

test/spec/Feature/OptionsSpec.hs

@@ -16,7 +16,7 @@ import SpecHelper
 spec :: PgVersion -> SpecWith ((), Application)
 spec actualPgVersion = describe "Allow header" $ do
   context "a table" $ do
-    it "includes read/write verbs for writeable table" $ do
+    it "includes read/write methods for writeable table" $ do
       r <- request methodOptions "/items" [] ""
       liftIO $
         simpleHeaders r `shouldSatisfy`
@@ -24,7 +24,7 @@ spec actualPgVersion = describe "Allow header" $ do
 
   when (actualPgVersion >= pgVersion100) $
     context "a partitioned table" $ do
-      it "includes read/write verbs for writeable partitioned tables" $ do
+      it "includes read/write methods for writeable partitioned tables" $ do
         r <- request methodOptions "/car_models" [] ""
         liftIO $
           simpleHeaders r `shouldSatisfy`
@@ -37,50 +37,50 @@ spec actualPgVersion = describe "Allow header" $ do
 
   context "a view" $ do
     context "auto updatable" $ do
-      it "includes read/write verbs for auto updatable views with pk" $ do
+      it "includes read/write methods for auto updatable views with pk" $ do
         r <- request methodOptions "/projects_auto_updatable_view_with_pk" [] ""
         liftIO $
           simpleHeaders r `shouldSatisfy`
             matchHeader "Allow" "OPTIONS,GET,HEAD,POST,PUT,PATCH,DELETE"
 
-      it "includes read/write verbs for auto updatable views without pk" $ do
+      it "includes read/write methods for auto updatable views without pk" $ do
         r <- request methodOptions "/projects_auto_updatable_view_without_pk" [] ""
         liftIO $
           simpleHeaders r `shouldSatisfy`
             matchHeader "Allow" "OPTIONS,GET,HEAD,POST,PATCH,DELETE"
 
     context "non auto updatable" $ do
-      it "includes read verbs for non auto updatable views" $ do
+      it "includes read methods for non auto updatable views" $ do
         r <- request methodOptions "/projects_view_without_triggers" [] ""
         liftIO $
           simpleHeaders r `shouldSatisfy`
             matchHeader "Allow" "OPTIONS,GET,HEAD"
 
-      it "includes read/write verbs for insertable, updatable and deletable views with pk" $ do
+      it "includes read/write methods for insertable, updatable and deletable views with pk" $ do
         r <- request methodOptions "/projects_view_with_all_triggers_with_pk" [] ""
         liftIO $
           simpleHeaders r `shouldSatisfy`
             matchHeader "Allow" "OPTIONS,GET,HEAD,POST,PUT,PATCH,DELETE"
 
-      it "includes read/write verbs for insertable, updatable and deletable views without pk" $ do
+      it "includes read/write methods for insertable, updatable and deletable views without pk" $ do
         r <- request methodOptions "/projects_view_with_all_triggers_without_pk" [] ""
         liftIO $
           simpleHeaders r `shouldSatisfy`
             matchHeader "Allow" "OPTIONS,GET,HEAD,POST,PATCH,DELETE"
 
-      it "includes read and insert verbs for insertable views" $ do
+      it "includes read and insert methods for insertable views" $ do
         r <- request methodOptions "/projects_view_with_insert_trigger" [] ""
         liftIO $
           simpleHeaders r `shouldSatisfy`
             matchHeader "Allow" "OPTIONS,GET,HEAD,POST"
 
-      it "includes read and update verbs for updatable views" $ do
+      it "includes read and update methods for updatable views" $ do
         r <- request methodOptions "/projects_view_with_update_trigger" [] ""
         liftIO $
           simpleHeaders r `shouldSatisfy`
             matchHeader "Allow" "OPTIONS,GET,HEAD,PATCH"
 
-      it "includes read and delete verbs for deletable views" $ do
+      it "includes read and delete methods for deletable views" $ do
         r <- request methodOptions "/projects_view_with_delete_trigger" [] ""
         liftIO $
           simpleHeaders r `shouldSatisfy`

test/spec/Feature/Query/ErrorSpec.hs

@@ -35,7 +35,7 @@ spec = do
             {"hint": null,
              "details": null,
              "code": "PGRST117",
-             "message":"Unsupported HTTP verb: CONNECT"}|]
+             "message":"Unsupported HTTP method: CONNECT"}|]
           { matchStatus = 405 }
 
     it "should return 405 for TRACE method" $
@@ -47,7 +47,7 @@ spec = do
             {"hint": null,
              "details": null,
              "code": "PGRST117",
-             "message":"Unsupported HTTP verb: TRACE"}|]
+             "message":"Unsupported HTTP method: TRACE"}|]
           { matchStatus = 405 }
 
     it "should return 405 for OTHER method" $
@@ -59,5 +59,5 @@ spec = do
             {"hint": null,
              "details": null,
              "code": "PGRST117",
-             "message":"Unsupported HTTP verb: OTHER"}|]
+             "message":"Unsupported HTTP method: OTHER"}|]
           { matchStatus = 405 }

test/spec/Feature/Query/RpcSpec.hs

@@ -516,11 +516,11 @@ spec actualPgVersion =
           simpleStatus p `shouldBe` internalServerError500
           isErrorFormat (simpleBody p) `shouldBe` True
 
-    context "unsupported verbs" $ do
+    context "unsupported method" $ do
       it "DELETE fails" $
         request methodDelete "/rpc/sayhello" [] ""
           `shouldRespondWith`
-          [json|{"message":"Bad Request","code":"PGRST101","details":null,"hint":null}|]
+          [json|{"message":"Cannot use the DELETE method on RPC","code":"PGRST101","details":null,"hint":null}|]
           { matchStatus  = 405
           , matchHeaders = [matchContentTypeJson]
           }