jimmy/postgrest
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat: Add explicit headers-only POST request using Prefer header

Browse Source 
Allows using header "Prefer=headers-only" explicitly to get a response with only a Location header.

BREAKING CHANGE: Change default for POST request from headers-only to minimal

Resolves #1656
This commit is contained in:
laurenceisla
2021-04-14 00:14:12 +02:00
committed by GitHub
parent cd09cc6c52
commit 4b46c4eff3
3 changed files with 37 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/Feature/InsertSpec.hs
+32 -13
View File
@@ -111,15 +111,23 @@ spec actualPgVersion = do
, "Content-Range" <:> "*/*" ]
}
context "requesting no representation" $
context "requesting headers only representation" $
it "should not throw and return location header when selecting without PK" $
request methodPost "/projects?select=name,client_id" []
request methodPost "/projects?select=name,client_id" [("Prefer", "return=headers-only")]
[json|{"id":11,"name":"New Project","client_id":2}|] `shouldRespondWith` ""
{ matchStatus = 201
, matchHeaders = [ "Location" <:> "/projects?id=eq.11"
, "Content-Range" <:> "*/*" ]
}
context "requesting no representation" $
it "should not throw and return no location header when selecting without PK" $
request methodPost "/projects?select=name,client_id" []
[json|{"id":12,"name":"New Project","client_id":2}|] `shouldRespondWith` ""
{ matchStatus = 201
, matchHeaders = [ matchHeaderAbsent hLocation ]
}
context "from an html form" $
it "accepts disparate json types" $ do
request methodPost "/menagerie"
@@ -140,7 +148,7 @@ spec actualPgVersion = do
`shouldRespondWith`
[json|""|]
post "/auto_incrementing_pk"
request methodPost "/auto_incrementing_pk" [("Prefer", "return=headers-only")]
[json| { "non_nullable_string":"not null"} |]
`shouldRespondWith`
""
@@ -508,13 +516,24 @@ spec actualPgVersion = do
""
{ matchStatus = 201 }
describe "Inserting into VIEWs" $
it "returns a location header" $
post "/compound_pk_view"
[json|{"k1":1,"k2":"test","extra":2}|]
`shouldRespondWith`
""
{ matchStatus = 201
, matchHeaders = [ "Location" <:> "/compound_pk_view?k1=eq.1&k2=eq.test"
, "Content-Range" <:> "*/*" ]
}
describe "Inserting into VIEWs" $ do
context "requesting no representation" $
it "succeeds with 201" $
post "/compound_pk_view"
[json|{"k1":1,"k2":"test","extra":2}|]
`shouldRespondWith`
""
{ matchStatus = 201
, matchHeaders = [ matchHeaderAbsent hLocation ]
}
context "requesting header only representation" $
it "returns a location header" $
request methodPost "/compound_pk_view" [("Prefer", "return=headers-only")]
[json|{"k1":1,"k2":"test","extra":2}|]
`shouldRespondWith`
""
{ matchStatus = 201
, matchHeaders = [ "Location" <:> "/compound_pk_view?k1=eq.1&k2=eq.test"
, "Content-Range" <:> "*/*" ]
}