jimmy/postgrest
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: correlated subquery for o2m query

Browse Source 
Improves the query costs a bit as shown in the tests and reduces code.
This commit is contained in:
steve-chavez
2022-08-06 21:42:53 -05:00
committed by Steve Chavez
parent c050b61db8
commit 3648986aa8
2 changed files with 31 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/spec/Feature/Query/PlanSpec.hs
+7 -7
View File
@@ -14,8 +14,8 @@ import Test.Hspec hiding (pendingWith)
import Test.Hspec.Wai
import Test.Hspec.Wai.JSON
import PostgREST.Config.PgVersion (PgVersion, pgVersion120,
pgVersion130, pgVersion100)
import PostgREST.Config.PgVersion (PgVersion, pgVersion100,
pgVersion120, pgVersion130)
import Protolude hiding (get)
import SpecHelper
@@ -274,8 +274,8 @@ spec actualPgVersion = do
let totalCost = simpleBody r ^? nth 0 . key "Plan" . key "Total Cost"
liftIO $ totalCost `shouldBe`
if actualPgVersion > pgVersion120
then Just [aesonQQ|58.26|]
else Just [aesonQQ|33.25|]
then Just [aesonQQ|33.25|]
else Just [aesonQQ|33.27|]
it "a many to one doesn't surpass a threshold" $ do
r <- request methodGet "/projects?select=*,clients(*)&id=eq.1"
@@ -293,9 +293,9 @@ spec actualPgVersion = do
let totalCost = simpleBody r ^? nth 0 . key "Plan" . key "Total Cost"
liftIO $ totalCost `shouldBe`
if | actualPgVersion > pgVersion120 -> Just [aesonQQ|130.44|]
| actualPgVersion > pgVersion100 -> Just [aesonQQ|69.34|]
| otherwise -> Just [aesonQQ|70.79|]
if | actualPgVersion > pgVersion120 -> Just [aesonQQ|69.34|]
| actualPgVersion > pgVersion100 -> Just [aesonQQ|69.36|]
| otherwise -> Just [aesonQQ|70.81|]
disabledSpec :: SpecWith ((), Application)
disabledSpec =