From 2d340e8a8c60af423d66b4e96b8e90b7daac1bdd Mon Sep 17 00:00:00 2001
From: Wolfgang Walther <walther@technowledgy.de>
Date: Sun, 21 Jun 2026 16:54:28 +0200
Subject: [PATCH] nix(loadtest): refactor generate_jwt -> generate_target

This makes the next change easier to do, but should be easier to review
step-by-step.
---
 nix/tools/generate_targets.py | 30 ++++++++++++++++--------------
 1 file changed, 16 insertions(+), 14 deletions(-)

diff --git a/nix/tools/generate_targets.py b/nix/tools/generate_targets.py
index 5f9769063..b8d76edc7 100644
--- a/nix/tools/generate_targets.py
+++ b/nix/tools/generate_targets.py
@@ -24,12 +24,12 @@ URL = "http://postgrest"
 secret_key = b"reallyreallyreallyreallyverysafe"
 
 
-def generate_jwt(
+def generate_target(
     now: int,
     exp_inc: Optional[int],
     rsa_private_key: Optional[jwt.algorithms.RSAAlgorithm],
-) -> str:
-    """Generate an HS256 or RS256 JWT"""
+) -> list[str]:
+    """Generate a target using an HS256 or RS256 JWT"""
     payload = {
         "sub": f"user_{random.getrandbits(32)}",
         "iat": now,
@@ -45,13 +45,13 @@ def generate_jwt(
     else:
         key = rsa_private_key
         alg = "RS256"
-    return jwt.encode(payload, key, alg)
+    token = jwt.encode(payload, key, alg)
 
-
-def append_targets(lines: list[str], token: str):
-    lines.append(f"OPTIONS {URL}/authors_only")
-    lines.append(f"Authorization: Bearer {token}")
-    lines.append("")  # blank line to separate requests
+    return [
+        f"OPTIONS {URL}/authors_only",
+        f"Authorization: Bearer {token}",
+        "",  # blank line to separate requests
+    ]
 
 
 # we use this to chain commands on loadtest.nix
@@ -150,14 +150,16 @@ def main():
         run_postgrest_time = 2
 
         for i in range(ntargets):
-            token = generate_jwt(now, run_postgrest_time + i // 1000, rsa_private_key)
-            append_targets(lines, token)
+            target = generate_target(
+                now, run_postgrest_time + i // 1000, rsa_private_key
+            )
+            lines.extend(target)
 
     else:
-        tokens = [generate_jwt(now, None, rsa_private_key) for _ in range(nsamples)]
+        targets = [generate_target(now, None, rsa_private_key) for _ in range(nsamples)]
         for i in range(ntargets):
-            token = random.choice(tokens)
-            append_targets(lines, token)
+            target = random.choice(targets)
+            lines.extend(target)
 
     try:
         with open(args.targets_path, "w") as f: