From 28dad7fca16bdb8813d805b55dde933da08024f5 Mon Sep 17 00:00:00 2001 From: Stephen Diehl Date: Thu, 7 Apr 2016 17:14:42 -0400 Subject: [PATCH] fix warnings --- protolude.cabal | 1 + src/Debug.hs | 15 ++++++++------- src/Either.hs | 2 +- src/Function.hs | 0 src/Protolude.hs | 14 +++++++------- 5 files changed, 17 insertions(+), 15 deletions(-) delete mode 100644 src/Function.hs diff --git a/protolude.cabal b/protolude.cabal index 942553ea9..2ad777ed4 100644 --- a/protolude.cabal +++ b/protolude.cabal @@ -26,6 +26,7 @@ library Debug List Monad + Unsafe default-extensions: NoImplicitPrelude diff --git a/src/Debug.hs b/src/Debug.hs index 0e3eaade4..9e843f35c 100644 --- a/src/Debug.hs +++ b/src/Debug.hs @@ -14,33 +14,34 @@ module Debug ( import qualified Prelude as P import qualified Debug.Trace as T ---{-# WARNING undefined "Do not use 'undefined' in production code" #-} +{-# WARNING undefined "'undefined' remains in code" #-} undefined :: a undefined = P.undefined ---{-# WARNING error "Do not use 'error' in production code" #-} +{-# WARNING error "'error' remains in code" #-} error :: P.String -> a error = P.error ---{-# WARNING trace "Do not use 'trace' in production code" #-} +{-# WARNING trace "'trace' remains in code" #-} trace :: P.String -> a -> a trace = T.trace ---{-# WARNING trace "Do not use 'trace' in production code" #-} +{-# WARNING traceShow "'traceShow' remains in code" #-} traceShow :: P.Show a => a -> a traceShow a = T.trace (P.show a) a ---{-# WARNING trace "Do not use 'trace' in production code" #-} +{-# WARNING traceShowM "'traceShowM' remains in code" #-} traceShowM :: (P.Show a, P.Monad m) => a -> m () traceShowM a = T.traceM (P.show a) ---{-# WARNING traceM "Do not use 'traceM' in production code" #-} +{-# WARNING traceM "'traceM' remains in code" #-} traceM :: P.Monad m => P.String -> m () traceM = T.traceM ---{-# WARNING traceIO "Do not use 'traceIO' in production code" #-} +{-# WARNING traceIO "'traceIO' remains in code" #-} traceIO :: P.String -> P.IO () traceIO = T.traceIO +{-# WARNING notImplemented "'notImplemented' remains in code" #-} notImplemented :: a notImplemented = P.error "Not implemented" diff --git a/src/Either.hs b/src/Either.hs index 1e7809a22..416c372d2 100644 --- a/src/Either.hs +++ b/src/Either.hs @@ -1,4 +1,4 @@ -module P.Either ( +module Either ( maybeToLeft , maybeToRight , leftToMaybe diff --git a/src/Function.hs b/src/Function.hs deleted file mode 100644 index e69de29bb..000000000 diff --git a/src/Protolude.hs b/src/Protolude.hs index 1c56561cd..a5054b338 100644 --- a/src/Protolude.hs +++ b/src/Protolude.hs @@ -84,7 +84,13 @@ import Data.List as X ( , reverse , replicate ) +import Data.Map as X (Map) +import Data.Set as X (Set) +import Data.Sequence as X (Seq) +import Data.IntMap as X (IntMap) +import Data.IntSet as X (IntSet) +-- Monad transformers import Control.Monad.State as X ( MonadState, State, @@ -127,13 +133,6 @@ import Control.Monad.Trans as X ( liftIO, ) --- Common data structure types -import Data.Map as X (Map) -import Data.Set as X (Set) -import Data.Sequence as X (Seq) -import Data.IntMap as X (IntMap) -import Data.IntSet as X (IntSet) - -- Base types import Data.Int as X import Data.Bits as X @@ -166,6 +165,7 @@ import GHC.Exts as X ( , the ) +-- Genericss import GHC.Generics ( Generic(..) , Rep