remove the db-embed-default-join config

test/io-tests/configs/expected/aliases.config

@@ -12,7 +12,6 @@ db-schemas = "provided_through_alias"
 db-config = "false"
 db-tx-end = "commit"
 db-uri = "required"
-db-embed-default-join = "left"
 db-use-legacy-gucs = true
 jwt-aud = ""
 jwt-role-claim-key = ".\"aliased\""

test/io-tests/configs/expected/boolean-numeric.config

@@ -12,7 +12,6 @@ db-schemas = "required"
 db-config = "false"
 db-tx-end = "commit"
 db-uri = "required"
-db-embed-default-join = "left"
 db-use-legacy-gucs = true
 jwt-aud = ""
 jwt-role-claim-key = ".\"role\""

test/io-tests/configs/expected/boolean-string.config

@@ -12,7 +12,6 @@ db-schemas = "required"
 db-config = "false"
 db-tx-end = "commit"
 db-uri = "required"
-db-embed-default-join = "left"
 db-use-legacy-gucs = true
 jwt-aud = ""
 jwt-role-claim-key = ".\"role\""

test/io-tests/configs/expected/defaults.config

@@ -12,7 +12,6 @@ db-schemas = "required"
 db-config = "false"
 db-tx-end = "commit"
 db-uri = "required"
-db-embed-default-join = "left"
 db-use-legacy-gucs = true
 jwt-aud = ""
 jwt-role-claim-key = ".\"role\""

test/io-tests/configs/expected/no-defaults-with-db-other-authenticator.config

@@ -12,7 +12,6 @@ db-schemas = "test,other_tenant1,other_tenant2"
 db-config = "true"
 db-tx-end = "rollback-allow-override"
 db-uri = "<REPLACED_WITH_DB_URI>"
-db-embed-default-join = "inner"
 db-use-legacy-gucs = false
 jwt-aud = "https://otherexample.org"
 jwt-role-claim-key = ".\"other\".\"role\""

test/io-tests/configs/expected/no-defaults-with-db.config

@@ -12,7 +12,6 @@ db-schemas = "test,tenant1,tenant2"
 db-config = "true"
 db-tx-end = "commit-allow-override"
 db-uri = "<REPLACED_WITH_DB_URI>"
-db-embed-default-join = "inner"
 db-use-legacy-gucs = false
 jwt-aud = "https://example.org"
 jwt-role-claim-key = ".\"a\".\"role\""

test/io-tests/configs/expected/no-defaults.config

@@ -12,7 +12,6 @@ db-schemas = "multi,tenant,setup"
 db-config = "false"
 db-tx-end = "rollback-allow-override"
 db-uri = "tmp_db"
-db-embed-default-join = "inner"
 db-use-legacy-gucs = false
 jwt-aud = "https://postgrest.org"
 jwt-role-claim-key = ".\"user\"[0].\"real-role\""

test/io-tests/configs/expected/types.config

@@ -12,7 +12,6 @@ db-schemas = "required"
 db-config = "true"
 db-tx-end = "commit"
 db-uri = "required"
-db-embed-default-join = "left"
 db-use-legacy-gucs = true
 jwt-aud = ""
 jwt-role-claim-key = ".\"role\""

test/io-tests/configs/no-defaults.config

@@ -12,7 +12,6 @@ db-schemas = "multi,   tenant,setup"
 db-config = "false"
 db-tx-end = "rollback-allow-override"
 db-uri = "tmp_db"
-db-embed-default-join = "inner"
 db-use-legacy-gucs = false
 jwt-aud = "https://postgrest.org"
 jwt-role-claim-key = ".user[0].\"real-role\""

test/io-tests/test_io.py

@@ -440,21 +440,6 @@ def test_invalid_openapi_mode(invalidopenapimodes, defaultenv):
                 print(line)
 
 
-@pytest.mark.parametrize("invalidjointypes", FIXTURES["invalidjointypes"])
-def test_invalid_db_embed_default_join(invalidjointypes, defaultenv):
-    "Given an invalid db-embed-default-join, Postgrest should exit with a non-zero exit code."
-    env = {
-        **defaultenv,
-        "PGRST_DB_EMBED_DEFAULT_JOIN": invalidjointypes,
-    }
-
-    with pytest.raises(PostgrestError):
-        dump = dumpconfig(CONFIGSDIR / "defaults.config", env=env)
-        for line in dump.split("\n"):
-            if line.startswith("db-embed-default-join"):
-                print(line)
-
-
 def test_iat_claim(defaultenv):
     """
     A claim with an 'iat' (issued at) attribute should be successful.